From 42f3be7df0ee1405d0bee56952bb1a2f93a060c2 Mon Sep 17 00:00:00 2001
From: mirabilos <thorsten.glaser@teckids.org>
Date: Wed, 4 Sep 2019 00:27:10 +0200
Subject: [PATCH] Catch when no lesson was given or can be autodiscovered.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

A nicer error page was supposed to be there, but apparently isn’t.
---
 biscuit/apps/alsijil/views.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/biscuit/apps/alsijil/views.py b/biscuit/apps/alsijil/views.py
index ce6b2adf4..1c9ab27a5 100644
--- a/biscuit/apps/alsijil/views.py
+++ b/biscuit/apps/alsijil/views.py
@@ -3,7 +3,7 @@ from typing import Optional
 
 from django.contrib.auth.decorators import login_required
 from django.db.models import Exists, OuterRef, Q
-from django.http import HttpRequest, HttpResponse
+from django.http import HttpRequest, HttpResponse, HttpResponseNotFound
 from django.shortcuts import render
 from django.views.decorators.cache import cache_page
 
@@ -71,6 +71,9 @@ def lesson(request: HttpRequest, week: Optional[int] = None, period_id: Optional
 
         context['lesson_documentation_form'] = lesson_documentation_form
         context['personal_note_formset'] = personal_note_formset
+    else:
+        #XXX TODO: nice error page (“no lesson currently running for you?” or so)
+        return HttpResponseNotFound("no current lesson found for you")
 
     return render(request, 'alsijil/lesson.html', context)
 
-- 
GitLab