From 58ff168416ae5455a72fbdd06a2ff9cdc746f699 Mon Sep 17 00:00:00 2001
From: Dominik George <dominik.george@teckids.org>
Date: Mon, 2 Sep 2019 17:01:43 +0200
Subject: [PATCH] Fix issues reported by pylama.
---
biscuit/apps/alsijil/forms.py | 5 ++---
biscuit/apps/alsijil/views.py | 5 ++---
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/biscuit/apps/alsijil/forms.py b/biscuit/apps/alsijil/forms.py
index 88b9d9a0a..6a84fdbae 100644
--- a/biscuit/apps/alsijil/forms.py
+++ b/biscuit/apps/alsijil/forms.py
@@ -24,10 +24,9 @@ class PersonalNoteForm(forms.ModelForm):
super().__init__(*args, **kwargs)
self.fields['person_name'].widget.attrs.update(
{'class': 'alsijil-lesson-personal-note-name'})
- try:
+
+ if self.instance and getattr(self.instance, 'person', None):
self.fields['person_name'].initial = str(self.instance.person)
- except:
- pass
class SelectForm(forms.Form):
diff --git a/biscuit/apps/alsijil/views.py b/biscuit/apps/alsijil/views.py
index d145d5fe5..5cf9cfb38 100644
--- a/biscuit/apps/alsijil/views.py
+++ b/biscuit/apps/alsijil/views.py
@@ -2,12 +2,11 @@ from collections import OrderedDict
from typing import Optional
from django.contrib.auth.decorators import login_required
-from django.db.models import Count, Q
+from django.db.models import Q
from django.http import HttpRequest, HttpResponse
from django.shortcuts import render
-from django.utils.translation import ugettext as _
-from biscuit.apps.chronos.models import Lesson, LessonPeriod, TimePeriod
+from biscuit.apps.chronos.models import LessonPeriod, TimePeriod
from biscuit.apps.chronos.util import current_lesson_periods, current_week, week_days
from biscuit.core.models import Group
--
GitLab