From 81394b035184d140b6cfd8dadba3efb8bee968cb Mon Sep 17 00:00:00 2001
From: mirabilos <thorsten.glaser@teckids.org>
Date: Wed, 4 Sep 2019 00:10:08 +0200
Subject: [PATCH] Fetch persons for PersonalNote formset eagerly.
Should cut SQL queries for lessons about into half.
---
biscuit/apps/alsijil/views.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/biscuit/apps/alsijil/views.py b/biscuit/apps/alsijil/views.py
index e5601cb58..a8ccadc10 100644
--- a/biscuit/apps/alsijil/views.py
+++ b/biscuit/apps/alsijil/views.py
@@ -58,7 +58,7 @@ def lesson(request: HttpRequest, week: Optional[int] = None, period_id: Optional
])
# Create a formset that holds all personal notes for all persons in this lesson
- persons_qs = PersonalNote.objects.filter(
+ persons_qs = PersonalNote.objects.select_related('person').filter(
lesson_period=lesson_period, week=wanted_week)
personal_note_formset = PersonalNoteFormSet(
request.POST or None, queryset=persons_qs, prefix='personal_notes')
--
GitLab