From a31e644f47b5f05496f3e891a02d1b8850b1980d Mon Sep 17 00:00:00 2001
From: Dominik George <nik@naturalnet.de>
Date: Thu, 22 Aug 2019 22:56:02 +0200
Subject: [PATCH] Do not create documentation for non-existing lesson.

---
 biscuit/apps/alsijil/views.py | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/biscuit/apps/alsijil/views.py b/biscuit/apps/alsijil/views.py
index 8fe7317eb..1a8e1ab28 100644
--- a/biscuit/apps/alsijil/views.py
+++ b/biscuit/apps/alsijil/views.py
@@ -27,14 +27,15 @@ def lesson(request: HttpRequest, week: Optional[int] = None, period_id: Optional
     context['lesson_period'] = lesson_period
     context['week'] = wanted_week
 
-    lesson_documentation, created = LessonDocumentation.objects.get_or_create(lesson_period=lesson_period, week=wanted_week)
-    lesson_documentation_form = LessonDocumentationForm(request.POST or None, instance=lesson_documentation)
+    if lesson_period:
+        lesson_documentation, created = LessonDocumentation.objects.get_or_create(lesson_period=lesson_period, week=wanted_week)
+        lesson_documentation_form = LessonDocumentationForm(request.POST or None, instance=lesson_documentation)
 
-    if request.method == 'POST':
-        if request.POST.get('action', None) == 'lesson_documentation':
-            if lesson_documentation_form.is_valid():
-                lesson_documentation_form.save()
+        if request.method == 'POST':
+            if request.POST.get('action', None) == 'lesson_documentation':
+                if lesson_documentation_form.is_valid():
+                    lesson_documentation_form.save()
 
-    context['lesson_documentation_form'] = lesson_documentation_form
+        context['lesson_documentation_form'] = lesson_documentation_form
 
     return render(request, 'alsijil/lesson.html', context)
-- 
GitLab