From b0a2e9b9d02c155f5b22f966a62d94ac4d4aa99b Mon Sep 17 00:00:00 2001
From: Hangzhi Yu <hangzhi@protonmail.com>
Date: Sat, 16 Mar 2024 02:55:46 +0100
Subject: [PATCH] Drop checks for course group owner-/membership in predicates
---
aleksis/apps/alsijil/util/predicates.py | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/aleksis/apps/alsijil/util/predicates.py b/aleksis/apps/alsijil/util/predicates.py
index c27796e4a..e33704317 100644
--- a/aleksis/apps/alsijil/util/predicates.py
+++ b/aleksis/apps/alsijil/util/predicates.py
@@ -354,8 +354,6 @@ def is_lesson_event_member(user: User, obj: LessonEvent):
or a members of the course, if the lesson event has one.
"""
if obj:
- if obj.course and is_course_member(user, obj.course):
- return True
for g in obj.groups.all():
if user.person in g.members.all():
return True
@@ -372,8 +370,6 @@ def is_lesson_event_group_owner(user: User, obj: LessonEvent):
or a owner of any group linked to the course, if the lesson event has one.
"""
if obj:
- if obj.course and is_course_group_owner(user, obj.course):
- return True
for g in obj.groups.all():
if user.person in g.owners.all():
return True
@@ -396,8 +392,6 @@ def can_view_documentation(user: User, obj: Documentation):
if obj.course:
return (
is_course_teacher(user, obj.course)
- | is_course_member(user, obj.course)
- | is_course_group_owner(user, obj.course)
)
return False
@@ -411,5 +405,5 @@ def can_edit_documentation(user: User, obj: Documentation):
user, obj.lesson_event
)
if obj.course:
- return is_course_teacher(user, obj.course) | is_course_group_owner(user, obj.course)
+ return is_course_teacher(user, obj.course)
return False
--
GitLab