From f1e813d120331a96bc3a6a7347e4d0c75408e92d Mon Sep 17 00:00:00 2001 From: Jonathan Weth <git@jonathanweth.de> Date: Fri, 8 Nov 2024 19:09:38 +0100 Subject: [PATCH] Fix empty querysets --- aleksis/apps/chronos/models.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/aleksis/apps/chronos/models.py b/aleksis/apps/chronos/models.py index f3e73316..0e09dcf9 100644 --- a/aleksis/apps/chronos/models.py +++ b/aleksis/apps/chronos/models.py @@ -7,7 +7,6 @@ from datetime import date from typing import Any from django.contrib.contenttypes.models import ContentType -from django.core.exceptions import PermissionDenied from django.core.validators import MinValueValidator from django.db import models from django.db.models import Q, QuerySet @@ -482,7 +481,7 @@ class LessonEvent(CalendarEvent): obj = get_el_by_pk(request, type_.lower(), obj_id) if not request.user.has_perm("chronos.view_timetable_rule", obj): - raise PermissionDenied() + return LessonEvent.objects.none() if type_ == "TEACHER": q = q & LessonEventQuerySet.for_teacher_q(obj_id) elif type_ == "PARTICIPANT": @@ -587,7 +586,7 @@ class SupervisionEvent(LessonEvent): obj = get_el_by_pk(request, type_.lower(), obj_id) if not request.user.has_perm("chronos.view_supervisions_rule", obj): - raise PermissionDenied() + return SupervisionEvent.objects.none() if type_ == "TEACHER": q = q & SupervisionEventQuerySet.for_teacher_q(obj_id) elif type_ == "GROUP": -- GitLab