From 5993b39e616e9723292ee65500c8535e5a4d71d0 Mon Sep 17 00:00:00 2001
From: Michael Bauer <michael-bauer@posteo.de>
Date: Wed, 12 Feb 2025 10:29:08 +0100
Subject: [PATCH 1/2] Fix name of absence_reasons-resolve-method
This broke permission-checking.
---
aleksis/apps/kolego/schema/__init__.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/aleksis/apps/kolego/schema/__init__.py b/aleksis/apps/kolego/schema/__init__.py
index 02d35ca..2193084 100644
--- a/aleksis/apps/kolego/schema/__init__.py
+++ b/aleksis/apps/kolego/schema/__init__.py
@@ -66,7 +66,7 @@ class Query(graphene.ObjectType):
)
@staticmethod
- def resolve_absencereasons(root, info, **kwargs) -> QuerySet:
+ def resolve_absence_reasons(root, info, **kwargs) -> QuerySet:
if not info.context.user.has_perm("kolego.fetch_absencereasons_rule"):
return []
return graphene_django_optimizer.query(
--
GitLab
From 95f7d8164d9df9bece0bf1c0148cde5f3b986d56 Mon Sep 17 00:00:00 2001
From: Michael Bauer <michael-bauer@posteo.de>
Date: Wed, 12 Feb 2025 10:43:51 +0100
Subject: [PATCH 2/2] Make absence reasons fetchable for all logged-in persons
again
---
aleksis/apps/kolego/schema/__init__.py | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/aleksis/apps/kolego/schema/__init__.py b/aleksis/apps/kolego/schema/__init__.py
index 2193084..006456e 100644
--- a/aleksis/apps/kolego/schema/__init__.py
+++ b/aleksis/apps/kolego/schema/__init__.py
@@ -69,14 +69,7 @@ class Query(graphene.ObjectType):
def resolve_absence_reasons(root, info, **kwargs) -> QuerySet:
if not info.context.user.has_perm("kolego.fetch_absencereasons_rule"):
return []
- return graphene_django_optimizer.query(
- get_objects_for_user(
- info.context.user,
- "kolego.view_absencereason",
- AbsenceReason.objects.all(),
- ),
- info,
- )
+ return graphene_django_optimizer.query(AbsenceReason.objects.all(), info)
@staticmethod
def resolve_absence_reason_tags(root, info, **kwargs) -> QuerySet:
--
GitLab