From 33902cb84cc53fec77278cbbe849157541259f0b Mon Sep 17 00:00:00 2001
From: Jonathan Weth <git@jonathanweth.de>
Date: Sat, 18 Jan 2020 14:11:16 +0100
Subject: [PATCH] Use get_object_or_404 for delete view to prevent server
errors
---
aleksis/apps/mensa/views.py | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/aleksis/apps/mensa/views.py b/aleksis/apps/mensa/views.py
index 2367423..f8b0abc 100644
--- a/aleksis/apps/mensa/views.py
+++ b/aleksis/apps/mensa/views.py
@@ -4,7 +4,7 @@ import time
from django.contrib.auth.decorators import login_required, permission_required
from django.http import FileResponse
-from django.shortcuts import render, redirect
+from django.shortcuts import render, redirect, get_object_or_404
from django.utils import timezone
from .models import Menu
@@ -34,7 +34,8 @@ def upload(request):
@login_required
@permission_required("mensa.add_menu")
def delete(request, id):
- Menu.objects.get(id=id).delete()
+ menu = get_object_or_404(Menu, pk=id)
+ menu.delete()
messages.success(request, _("The menu was deleted successfully."))
return redirect("menu_index")
--
GitLab