diff --git a/CHANGELOG.rst b/CHANGELOG.rst index 5dc97e91aca9e432842537292a497524d48276f5..c13f3964e44cab97fb4a26f7e60c2dd5b2e98421 100644 --- a/CHANGELOG.rst +++ b/CHANGELOG.rst @@ -20,6 +20,7 @@ Changed * Rewrite of frontend using Vuetify * Incorporate SPDX license list for app licenses on About page +* [Dev] The undocumented field `check` on `DataCheckResult` was renamed to `data_check` Fixed ~~~~~ diff --git a/aleksis/core/data_checks.py b/aleksis/core/data_checks.py index 47194ece7a30b3bdf6a4fa6fc9624fd9851d2be9..caed821d6633f3c2374f278af67032b7bdda41e9 100644 --- a/aleksis/core/data_checks.py +++ b/aleksis/core/data_checks.py @@ -202,7 +202,7 @@ class DataCheck: ct = ContentType.objects.get_for_model(instance) result, __ = DataCheckResult.objects.get_or_create( - check=cls.name, content_type=ct, object_id=instance.id + data_check=cls.name, content_type=ct, object_id=instance.id ) # Track all existing problems (for deleting old results) diff --git a/aleksis/core/migrations/0045_data_check_result_fix_check_field.py b/aleksis/core/migrations/0045_data_check_result_fix_check_field.py new file mode 100644 index 0000000000000000000000000000000000000000..3d72bd2733cb9b27684b5fc7832749ce42d93c8c --- /dev/null +++ b/aleksis/core/migrations/0045_data_check_result_fix_check_field.py @@ -0,0 +1,21 @@ +# Generated by Django 3.2.16 on 2022-12-16 11:50 + +from django.db import migrations, models +import django.utils.timezone +import oauth2_provider.generators +import oauth2_provider.models + + +class Migration(migrations.Migration): + + dependencies = [ + ('core', '0044_task_assignment_result_fetched'), + ] + + operations = [ + migrations.RenameField( + model_name='datacheckresult', + old_name='check', + new_name='data_check', + ), + ] diff --git a/aleksis/core/models.py b/aleksis/core/models.py index f01086c8cbe8c786ab5d2497df77e730212c7c1f..27954c2aa8e9fde4306c4ea4184ae9614cb08613 100644 --- a/aleksis/core/models.py +++ b/aleksis/core/models.py @@ -1164,7 +1164,7 @@ class GroupPreferenceModel(PerInstancePreferenceModel, PureDjangoModel): class DataCheckResult(ExtensibleModel): """Save the result of a data check for a specific object.""" - check = models.CharField( + data_check = models.CharField( max_length=255, verbose_name=_("Related data check task"), choices=DataCheckRegistry.data_checks_choices, @@ -1179,7 +1179,7 @@ class DataCheckResult(ExtensibleModel): @property def related_check(self) -> DataCheck: - return DataCheckRegistry.data_checks_by_name[self.check] + return DataCheckRegistry.data_checks_by_name[self.data_check] def solve(self, solve_option: str = "default"): self.related_check.solve(self, solve_option)