From 2894a9514edf83e0ab9619b8626b0c95dbd7da42 Mon Sep 17 00:00:00 2001
From: Hangzhi Yu <hangzhi@protonmail.com>
Date: Sun, 1 Aug 2021 14:28:31 +0200
Subject: [PATCH] Comment has_any_object function
---
aleksis/core/util/predicates.py | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/aleksis/core/util/predicates.py b/aleksis/core/util/predicates.py
index ec92aeeda..438383c96 100644
--- a/aleksis/core/util/predicates.py
+++ b/aleksis/core/util/predicates.py
@@ -75,14 +75,19 @@ def has_any_object(perm: str, klass):
Build predicate which checks whether a user has access
to objects with the provided permission or rule.
+ Differentiates between object-related permissions and rules.
"""
name = f"has_any_object:{perm}"
@predicate(name)
def fn(user: User) -> bool:
ct_perm = get_content_type_by_perm(perm)
+ # In case a object-related permission with the same ContentType class as the given class
+ # is passed, the optimized django-guardian get_objects_for_user function is used.
if ct_perm and ct_perm.model_class() == klass:
return get_objects_for_user(user, perm, klass).exists()
+ # In other cases, it is checked for each object of the given model whether the current user
+ # fulfills the given rule.
else:
return queryset_rules_filter(user, klass.objects.all(), perm).exists()
--
GitLab