From 43eed7553bb72ac1cc50917c9f5d5928f876e0cd Mon Sep 17 00:00:00 2001 From: Dominik George <dominik.george@teckids.org> Date: Fri, 14 Jan 2022 00:46:24 +0100 Subject: [PATCH] Use proper formatting methods for phone numbers --- CHANGELOG.rst | 1 + aleksis/core/templates/core/person/full.html | 8 ++++++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.rst b/CHANGELOG.rst index 9acd4a272..58f3bf247 100644 --- a/CHANGELOG.rst +++ b/CHANGELOG.rst @@ -13,6 +13,7 @@ Fixed ~~~~~ * Signup was forbidden even if it was enabled in settings +* Phone numbers were not properly linked and suboptimally formatted on person page `2.6`_ - 2022-01-10 ------------------- diff --git a/aleksis/core/templates/core/person/full.html b/aleksis/core/templates/core/person/full.html index d8c9101af..3cf3613b5 100644 --- a/aleksis/core/templates/core/person/full.html +++ b/aleksis/core/templates/core/person/full.html @@ -164,13 +164,17 @@ <i class="material-icons small">phone</i> </td> <td> - <a href="tel:{{ person.phone_number }}">{{ person.phone_number }}</a> + {% if person.phone_number %} + <a href="{{ person.phone_number.as_rfc3966 }}">{{ person.phone_number.as_international }}</a> + {% endif %} <small>({% trans "home number" %})</small> </td> </tr> <tr> <td> - <a href="tel:{{ person.mobile_number }}">{{ person.mobile_number }}</a> + {% if person.mobile_number %} + <a href="{{ person.mobile_number.as_rfc3966 }}">{{ person.mobile_number.as_international }}</a> + {% endif %} <small>({% trans "mobile number" %})</small> </td> </tr> -- GitLab