From 5f74b505cae7961e7d3358665b578321946f8d30 Mon Sep 17 00:00:00 2001
From: Julian Leucker <leuckerj@gmail.com>
Date: Mon, 4 May 2020 19:10:15 +0200
Subject: [PATCH] Delete empty favicons

---
 aleksis/core/apps.py | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/aleksis/core/apps.py b/aleksis/core/apps.py
index dd3c9b3a8..4f243858d 100644
--- a/aleksis/core/apps.py
+++ b/aleksis/core/apps.py
@@ -2,6 +2,7 @@ from typing import Any, List, Optional, Tuple
 
 import django.apps
 from django.http import HttpRequest
+from django.core.files.uploadedfile import TemporaryUploadedFile
 
 from dynamic_preferences.registries import preference_models
 
@@ -59,10 +60,15 @@ class CoreConfig(AppConfig):
             elif name in ("favicon", "pwa_icon"):
                 from favicon.models import Favicon  # noqa
 
-                Favicon.on_site.update_or_create(
-                    title=name,
-                    defaults={"isFavicon": name == "favicon", "faviconImage": new_value,},
-                )
+                is_favicon = name == "favicon"
+
+                if new_value:
+                    Favicon.on_site.update_or_create(
+                        title=name,
+                        defaults={"isFavicon": name == "favicon", "faviconImage": new_value, },
+                    )
+                else:
+                    Favicon.on_site.filter(title=name, isFavicon=is_favicon).delete()
 
     def post_migrate(
         self,
-- 
GitLab