From 645a39fe5a2a0045cf6c8ea44cebef17977fed77 Mon Sep 17 00:00:00 2001
From: Dominik George <dominik.george@teckids.org>
Date: Mon, 2 Sep 2019 16:52:12 +0200
Subject: [PATCH] Fix issues reported by pylama.
---
biscuit/core/tables.py | 1 -
biscuit/core/urls.py | 1 -
biscuit/core/util/core_helpers.py | 2 +-
biscuit/core/views.py | 1 -
dev.sh | 8 +++++++-
5 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/biscuit/core/tables.py b/biscuit/core/tables.py
index 0b57e2b11..39edd10b7 100644
--- a/biscuit/core/tables.py
+++ b/biscuit/core/tables.py
@@ -1,4 +1,3 @@
-from django.utils.translation import ugettext_lazy as _
import django_tables2 as tables
from django_tables2.utils import A
diff --git a/biscuit/core/urls.py b/biscuit/core/urls.py
index 4e382a2f6..f7d7df552 100644
--- a/biscuit/core/urls.py
+++ b/biscuit/core/urls.py
@@ -1,7 +1,6 @@
from django.apps import apps
from django.conf import settings
from django.conf.urls.static import static
-from django.contrib import admin
from django.urls import include, path
import debug_toolbar
diff --git a/biscuit/core/util/core_helpers.py b/biscuit/core/util/core_helpers.py
index ba6bc421e..992a51316 100644
--- a/biscuit/core/util/core_helpers.py
+++ b/biscuit/core/util/core_helpers.py
@@ -26,7 +26,7 @@ def get_app_packages() -> Sequence[str]:
# Add additional apps defined in module's INSTALLED_APPS constant
additional_apps = getattr(mod, 'INSTALLED_APPS', [])
for app in additional_apps:
- if not app in pkgs:
+ if app not in pkgs:
pkgs.append(app)
pkgs.append('biscuit.apps.%s' % pkg[1])
diff --git a/biscuit/core/views.py b/biscuit/core/views.py
index 69e15353b..987c538fd 100644
--- a/biscuit/core/views.py
+++ b/biscuit/core/views.py
@@ -1,7 +1,6 @@
from typing import Callable
from django.contrib.auth.decorators import login_required
-from django.conf import settings
from django.http import Http404, HttpRequest, HttpResponse
from django.shortcuts import get_object_or_404, render, redirect
from django_tables2 import RequestConfig
diff --git a/dev.sh b/dev.sh
index 70667f462..d592f9e7f 100755
--- a/dev.sh
+++ b/dev.sh
@@ -36,7 +36,13 @@ case "$1" in
poetry run sh -c "cd $d; autopep8 -i -r ."
done
;;
-
+ "pylama")
+ cd "$(dirname "$0")"
+ for d in biscuit/core apps/official/*/biscuit/apps/*; do
+ echo; echo "Entering $d."
+ poetry run sh -c "cd $d; pylama ."
+ done
+ ;;
*)
;;
esac
--
GitLab