From 9dd680ffdbec9d316a989dac9b0691e1131f2a9c Mon Sep 17 00:00:00 2001
From: Dominik George <dominik.george@teckids.org>
Date: Fri, 16 Dec 2022 12:53:02 +0100
Subject: [PATCH] Rename DataCheckResult.check to .data_check
---
CHANGELOG.rst | 1 +
.../0045_data_check_result_fix_check_field.py | 21 +++++++++++++++++++
aleksis/core/models.py | 4 ++--
3 files changed, 24 insertions(+), 2 deletions(-)
create mode 100644 aleksis/core/migrations/0045_data_check_result_fix_check_field.py
diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index 5dc97e91a..c13f3964e 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -20,6 +20,7 @@ Changed
* Rewrite of frontend using Vuetify
* Incorporate SPDX license list for app licenses on About page
+* [Dev] The undocumented field `check` on `DataCheckResult` was renamed to `data_check`
Fixed
~~~~~
diff --git a/aleksis/core/migrations/0045_data_check_result_fix_check_field.py b/aleksis/core/migrations/0045_data_check_result_fix_check_field.py
new file mode 100644
index 000000000..3d72bd273
--- /dev/null
+++ b/aleksis/core/migrations/0045_data_check_result_fix_check_field.py
@@ -0,0 +1,21 @@
+# Generated by Django 3.2.16 on 2022-12-16 11:50
+
+from django.db import migrations, models
+import django.utils.timezone
+import oauth2_provider.generators
+import oauth2_provider.models
+
+
+class Migration(migrations.Migration):
+
+ dependencies = [
+ ('core', '0044_task_assignment_result_fetched'),
+ ]
+
+ operations = [
+ migrations.RenameField(
+ model_name='datacheckresult',
+ old_name='check',
+ new_name='data_check',
+ ),
+ ]
diff --git a/aleksis/core/models.py b/aleksis/core/models.py
index f01086c8c..27954c2aa 100644
--- a/aleksis/core/models.py
+++ b/aleksis/core/models.py
@@ -1164,7 +1164,7 @@ class GroupPreferenceModel(PerInstancePreferenceModel, PureDjangoModel):
class DataCheckResult(ExtensibleModel):
"""Save the result of a data check for a specific object."""
- check = models.CharField(
+ data_check = models.CharField(
max_length=255,
verbose_name=_("Related data check task"),
choices=DataCheckRegistry.data_checks_choices,
@@ -1179,7 +1179,7 @@ class DataCheckResult(ExtensibleModel):
@property
def related_check(self) -> DataCheck:
- return DataCheckRegistry.data_checks_by_name[self.check]
+ return DataCheckRegistry.data_checks_by_name[self.data_check]
def solve(self, solve_option: str = "default"):
self.related_check.solve(self, solve_option)
--
GitLab