diff --git a/CHANGELOG.rst b/CHANGELOG.rst index 2f1deb8ad33766a3b4a4a5a8dc2ef3b7b683ac54..50eb362cd2e9c0e79882d923b3386fd680b5338c 100644 --- a/CHANGELOG.rst +++ b/CHANGELOG.rst @@ -63,7 +63,6 @@ Fixed * 2FA via messages or phone calls didn't work. * [Dev] Site reference on extensible models can no longer cause name clashes because of its related name. -* Links to data check objects did not work properly. Removed ~~~~~~~ diff --git a/aleksis/core/templates/core/data_check/list.html b/aleksis/core/templates/core/data_check/list.html index 00b0ceb3a9eefdb473b6fe97a2d2d693aee59b61..b192dcdc1623a05fa3ad7b3568b4b8bdc3622abf 100644 --- a/aleksis/core/templates/core/data_check/list.html +++ b/aleksis/core/templates/core/data_check/list.html @@ -2,7 +2,6 @@ {% extends "core/base.html" %} {% load data_helpers %} -{% load html_helpers %} {% load i18n %} {% load render_table from django_tables2 %} @@ -60,11 +59,9 @@ <td>{{ result.related_object }}</td> <td>{{ result.related_check.problem_name }}</td> <td> - {% if result.related_object.get_absolute_url %} - <a class="btn-flat waves-effect waves-light" href="{{ result.related_object.get_absolute_url|remove_prefix:"/django/" }}" target="_blank"> + <a class="btn-flat waves-effect waves-light" href="{{ result.related_object.get_absolute_url }}"> {% trans "Show object" %} </a> - {% endif %} </td> <td> {% for option_name, option in result.related_check.solve_options.items %} diff --git a/aleksis/core/templatetags/html_helpers.py b/aleksis/core/templatetags/html_helpers.py index 98608a084574994400bffe46c50f944b52296e24..8ca5be151d2edc39bf6787e9e51eabb3350714a0 100644 --- a/aleksis/core/templatetags/html_helpers.py +++ b/aleksis/core/templatetags/html_helpers.py @@ -1,6 +1,5 @@ import random import string -from urllib.parse import urlparse from django import template from django.shortcuts import reverse @@ -29,24 +28,6 @@ def add_class_to_el(value: str, arg: str) -> str: return str(soup) -@register.filter -def remove_prefix(value: str, prefix: str) -> str: - """Remove prefix of a url. - - :Example: - - .. code-block:: - - {{ object.get_absolute_url|remove_prefix: "/django/" }} - """ - url = urlparse(value) - - if url.path.startswith(prefix): - url = url._replace(path=url.path[len(prefix) :]) - - return url.geturl() - - @register.simple_tag def generate_random_id(prefix: str, length: int = 10) -> str: """Generate a random ID for templates.