From 446130361b24ed044dd861d221bf589383d49fe7 Mon Sep 17 00:00:00 2001 From: Jonathan Weth <git@jonathanweth.de> Date: Tue, 3 Aug 2021 21:07:43 +0200 Subject: [PATCH] Raise 404 error if live document has no current PDF file --- aleksis/apps/resint/views.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/aleksis/apps/resint/views.py b/aleksis/apps/resint/views.py index f987f38..4562dee 100644 --- a/aleksis/apps/resint/views.py +++ b/aleksis/apps/resint/views.py @@ -3,7 +3,7 @@ from typing import Any, Dict, Type from django.contrib.contenttypes.models import ContentType from django.db.models import QuerySet from django.forms import BaseModelForm, modelform_factory -from django.http import FileResponse, HttpRequest +from django.http import FileResponse, HttpRequest, Http404 from django.shortcuts import get_object_or_404 from django.urls import reverse_lazy from django.utils.decorators import method_decorator @@ -229,4 +229,7 @@ class LiveDocumentShowView(PermissionRequiredMixin, SingleObjectMixin, View): def get(self, request: HttpRequest, *args: Any, **kwargs: Any) -> FileResponse: live_document = self.get_object() + file = live_document.get_current_file() + if not file: + raise Http404 return FileResponse(live_document.get_current_file(), content_type="application/pdf") -- GitLab