Skip to content
Snippets Groups Projects
Verified Commit b84d3953 authored by Jonathan Weth's avatar Jonathan Weth :keyboard:
Browse files

Check only not empty personal notes in data checks

parent 0a6ddfe2
No related branches found
No related tags found
1 merge request!132Resolve "Data checks are also marking empty personal notes and lesson documentations"
Pipeline #5430 passed
......@@ -56,11 +56,15 @@ class NoPersonalNotesInCancelledLessonsDataCheck(DataCheck):
def check_data(cls):
from .models import PersonalNote
personal_notes = PersonalNote.objects.filter(
lesson_period__substitutions__cancelled=True,
lesson_period__substitutions__week=F("week"),
lesson_period__substitutions__year=F("year"),
).prefetch_related("lesson_period", "lesson_period__substitutions")
personal_notes = (
PersonalNote.objects.not_empty()
.filter(
lesson_period__substitutions__cancelled=True,
lesson_period__substitutions__week=F("week"),
lesson_period__substitutions__year=F("year"),
)
.prefetch_related("lesson_period", "lesson_period__substitutions")
)
for note in personal_notes:
logging.info(f"Check personal note {note}")
......@@ -119,7 +123,9 @@ class LessonDocumentationOnHolidaysDataCheck(DataCheck):
holidays = Holiday.objects.all()
documentations = LessonDocumentation.objects.not_empty().annotate(actual_date=weekday_to_date)
documentations = LessonDocumentation.objects.not_empty().annotate(
actual_date=weekday_to_date
)
q = Q()
for holiday in holidays:
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment