Check permission rules if they handle lessons with substitutions correctly

Currently, original teachers don't get access to their lessons if there are substitutions assigned to this lesson. This has to be fixed and we should check if there any similar issues.

added part::backend type::bug labels

created merge request !158 (merged) to address this issue

mentioned in merge request !158 (merged)

When drafting the access model in Alsijil, compeltely transferring the complete teacher role to a substitution teacher was intentional because only one teacher should be able to author notes for a lesson at any given time.

If this is to be changed, it needs to be discussed.

Yes, you're right. But the original teacher should be able to view the notes for the lesson at least. I will check that again.

Then again, we already depart from that, because nowadays lessons can have more than one teacher. Thus, we should probably treat substitutions the same as co-teaching…

Then I can remove the last commit?

First, you should provide argumentation. If you support my first position, or maybe the option to make the lesson read-only for the regular teacher, please document why. (Same for all other options; we should not make changes because someone says it might be a good idea without reasoning).

I think we should make the lesson writable for the original and the substitution teacher because of the following points:

• We already have to deal with the option that there can be more than one teacher which is able to edit a lesson documentation.
• The risk that the original teacher manipulates the data inserted by the substitution teacher is minimal.
• The original teacher should be able to edit personal notes afterwards to correct them if necessary (i. e. through student input).

Do we have a mechanism to notify the original author of a lesson documentation if it is changed by someone else afterwards?

In addition to the change history, nothing.

Please open an issue to implement that, then, and link it as follow-up issue in your MR.

Now tracked in #148

marked this issue as related to #148

closed with merge request !158 (merged)

mentioned in commit e94a0e7a