Absence dialog doesn't work

Wenn man das (+) Symbol zum Eintragen von Zeiträumen verwendet,
- lässt sich keine Eintragung für einen einzelnen Tag vornehmen - das zweite Datum darf nicht gleich dem ersten sein,
- stimmen die aufgelisteten Stunden nicht mit den tatsächlichen überein - es werden in der Regel weniger Stunden angezeigt, als wirklich erteilt wurden,
- werden nur Stunden entschuldigt, die vorher als abwesend eingetragen wurden - das ist ungünstig, weil versäumte Eintragungen für Abwesenheiten damit nicht ausgebügelt werden können, wie es vorher der Fall war.

added part::frontend source::customer::kath type::bug workflow::current-todo labels

The main issue we should focus on right now – the things above aren't confirmed yet – is the following behavior:

1. Set student absent for a whole day using the extend participation status feature.
2. Some, but not all teachers are doing their coursebook entries on this day – so participation statuses are not created for all lessons on this day
3. A week later, class teacher marks student excused for a the whole day using the absence creation form
4. One of teachers is doing his coursebook entry for the day the student was absent and is now excused

Question: Right now, there are probably two different absences in Kolego for this day and person, one with absent and one with excused status – or is the absence in Kolego updated? What is happening if the absences are overlapping? This has to be done correctly and the student definitely has to be marked as excused in step 4.

as far as I can reproduce this now, the extend participation status feature does not work at all – that is, when touching documentations with participants having a overlapping kolego absence created earlier on with said feature, that absence is not taken into regard when creating participation statuses

Right now, there are probably two different absences in Kolego for this day and person, one with absent and one with excused status – or is the absence in Kolego updated?

no, it is not. There are two overlapping kolego absences present as a result of the actions laid out above. Since, apparently, absences are not correctly taken into regard when documentations are touched/participation statuses are created (the issues seems to be that no fitting absences are found for the time span that the documentation covers), the student is also not marked as excused in step 4 of the sketched workflow.

thus, there should be three to-dos:

• Check & probably fix consideration of kolego absences when creating participations
• (after the to-do above has been done) Clarify how overlapping kolego absences are handled when automatically creating participations based on them – automatically take the newer one (based on creation timestamp) @hansegucker ?
• update fully overlapping kolego absences when new absence is created (in example: update initial "absent" absence to "excused") – question: are people supposed to be able to have more than one kolego absence? If yes, how do we decide when to update absences when they fully overlap? Should this happen at all, or is fixing the two points above enough @hansegucker ?

I am not completely sure what's the way to go. Please write this in AlekSIS-Devs so we can discuss this quickly.

The first to-do should probably be done asap.

Regarding the other two points: I don't believe that overlapping absences really make sense (e.g. a teacher is either sick or on vacation, but if they are sick on vacation, they are still on vacation…). So we should probably disallow overlapping absences. If we don't (or can't), then probably only update the newest one.

I also think that there shouldn't be overlapping Kolego absences as they create an inconsistent state.

Alright, first to-do will be solved via #333 (closed)

Regarding overlapping kolego absences: In a scenario in which some person has one longer absence and then (for whatever reason) a shorter absence is added which fully overlaps the first absence, what should happen? Should the first absence be split? Should the overlap be tolerated? I'm not sure if scenarios like this always represent an inconsistent state

Update regarding first to-do: the problem is to be found here AlekSIS/libs/django-pg-rrule#2 (closed)

Devmeeting decided: there should only be one absence per person at any given time. If an absence overlapping another absence is added, the older absences should be cut in order to give room for the new absence. See AlekSIS/onboarding/AlekSIS-App-Kolego#32 (closed)

assigned to @yuha

created branch 327-absence-dialog-doesn-t-work to address this issue

mentioned in merge request !436 (merged)

added workflow::discussing label

TODO: Make sure entering data for time spans in the future works (& also communicates to the user that their action had some effect)

.

while doing this, also have a look at #324 (closed)

closed with commit 28ec5cbc

mentioned in commit 28ec5cbc