[Full register] Only show personal notes of group members

In the lesson section are currently shown all personal notes related to this lesson period, no matter if the person is a member of the group or not.

changed milestone to %1.0a1

added part::backend part::frontend prio::1 type::bug labels

created merge request !70 (merged) to address this issue

mentioned in merge request !70 (merged)

assigned to @hansegucker

changed title from Only show group members in full register printout, too to [Full register] Only show personal notes of group members

changed the description

This behaviour is correct. If there is a personal note for a person for this lesson, then obviously they at least were a member of the group, and maybe left it later. Why should personal notes be discarded in that case?

Okay, that may be a reason to show the personal notes. But what is with students from other classes?

As in, a lesson is held in several classes (like WPU), but a register printout is created for only one of the groups? In that case, you only want to show the personal notes concerning members of this one group?

Yes.

How do you distinguish a person having been (re)moved later from a person that never was a group member?

Idea: When a personal note is created, it gets a second relation to the group it is related to, so we can later track it without relying on the person alone.

Seems like a good idea.

One thing I recognized just now: Persons, who where a member of the group sometime ago, also wont be displayed in the other pages (persons list, persons detail pages etc). How we deal with this behavior?

That's correct, those views are intended to provide the current state, whereas the class register is supposed to be a historical track record.

But I am speaking about the class register printout, not about other views.

Oh. Hmm... good question. They should probably include historical persons as well.

changed the description

closed via merge request !70 (merged)

mentioned in commit d045eccc

mentioned in commit 65ffbc22

mentioned in merge request !78 (merged)

mentioned in commit e08075f9