Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
A
AlekSIS-App-Alsijil
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Container Registry
Model registry
Operate
Environments
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
AlekSIS®
Official
AlekSIS-App-Alsijil
Merge requests
!363
Resolve "Add absence overview page"
Code
Review changes
Check out branch
Download
Patches
Plain diff
Merged
Resolve "Add absence overview page"
264-add-absence-overview-page
into
master
Overview
3
Commits
41
Pipelines
27
Changes
1
All threads resolved!
Hide all comments
Merged
Hangzhi Yu
requested to merge
264-add-absence-overview-page
into
master
9 months ago
Overview
3
Commits
41
Pipelines
27
Changes
1
All threads resolved!
Hide all comments
Expand
Closes
#264 (closed)
0
0
Merge request reports
Viewing commit
01a51440
Prev
Next
Show latest version
1 file
+
1
−
178
Inline
Compare changes
Side-by-side
Inline
Show whitespace changes
Show one file at a time
01a51440
Remove unused methods from Coursebook component
· 01a51440
Hangzhi Yu
authored
9 months ago
aleksis/apps/alsijil/frontend/components/coursebook/Coursebook.vue
+
1
−
178
Options
@@ -160,189 +160,12 @@ export default {
// computed should not have side effects
// but this was actually done before filters was refactored into
// its own component
this
.
resetDate
();
this
.
$refs
.
iterator
.
resetDate
();
// might skip query until both set = atomic
}
}
,
}
,
}
,
methods
:
{
resetDate
(
toDate
)
{
// Assure current date
console
.
log
(
"
Resetting date range
"
,
this
.
$route
.
hash
);
this
.
currentDate
=
toDate
||
this
.
$route
.
hash
?.
substring
(
1
);
if
(
!
this
.
currentDate
)
{
console
.
log
(
"
Set default date
"
);
this
.
setDate
(
DateTime
.
now
().
toISODate
());
}
const
date
=
DateTime
.
fromISO
(
this
.
currentDate
);
this
.
initDate
=
date
;
this
.
dateStart
=
date
.
minus
({
days
:
this
.
dayIncrement
}
).
toISODate
();
this
.
dateEnd
=
date
.
plus
({
days
:
this
.
dayIncrement
}
).
toISODate
();
}
,
transition
()
{
this
.
initDate
=
false
;
this
.
ready
=
true
;
}
,
groupDocsByDay
(
docs
)
{
// =>
{
dt
:
{
date
:
dt
,
docs
:
doc
...
}
...
}
const
docsByDay
=
docs
.
reduce
((
byDay
,
doc
)
=>
{
// This works with dummy. Does actual doc have dateStart instead?
const
day
=
DateTime
.
fromISO
(
doc
.
datetimeStart
).
startOf
(
"
day
"
);
byDay
[
day
]
??=
{
date
:
day
,
docs
:
[]
}
;
byDay
[
day
].
docs
.
push
(
doc
);
return
byDay
;
}
,
{
}
);
// => [
{
date
:
dt
,
docs
:
doc
...,
idx
:
idx
,
lastIdx
:
last
-
idx
}
...]
// sorting is necessary since backend can send docs unordered
return
Object
.
keys
(
docsByDay
)
.
sort
()
.
map
((
key
,
idx
,
{
length
}
)
=>
{
const
day
=
docsByDay
[
key
];
day
.
first
=
idx
===
0
;
const
lastIdx
=
length
-
1
;
day
.
last
=
idx
===
lastIdx
;
return
day
;
}
);
}
,
// docsByDay:
{
dt
:
[
dt
doc
...]
...
}
fetchMore
(
from
,
to
,
then
)
{
console
.
log
(
"
fetching
"
,
from
,
to
);
this
.
lastQuery
.
fetchMore
({
variables
:
{
dateStart
:
from
,
dateEnd
:
to
,
}
,
// Transform the previous result with new data
updateQuery
:
(
previousResult
,
{
fetchMoreResult
}
)
=>
{
console
.
log
(
"
Received more
"
);
then
();
return
{
items
:
previousResult
.
items
.
concat
(
fetchMoreResult
.
items
)
}
;
}
,
}
);
}
,
setDate
(
date
)
{
this
.
currentDate
=
date
;
if
(
!
this
.
hashUpdater
)
{
this
.
hashUpdater
=
window
.
requestIdleCallback
(()
=>
{
if
(
!
(
this
.
$route
.
hash
.
substring
(
1
)
===
this
.
currentDate
))
{
this
.
$router
.
replace
({
hash
:
this
.
currentDate
}
);
}
this
.
hashUpdater
=
false
;
}
);
}
}
,
fixScrollPos
(
height
,
top
)
{
this
.
$nextTick
(()
=>
{
if
(
height
<
document
.
documentElement
.
scrollHeight
)
{
document
.
documentElement
.
scrollTop
=
document
.
documentElement
.
scrollHeight
-
height
+
top
;
this
.
ready
=
true
;
}
else
{
// Update top, could have changed in the meantime.
this
.
fixScrollPos
(
height
,
document
.
documentElement
.
scrollTop
);
}
}
);
}
,
intersectHandler
(
date
,
first
,
last
)
{
let
once
=
true
;
return
(
entries
)
=>
{
const
entry
=
entries
[
0
];
if
(
entry
.
isIntersecting
)
{
if
(
entry
.
boundingClientRect
.
top
<=
this
.
topMargin
||
first
)
{
console
.
log
(
"
@
"
,
date
.
toISODate
());
this
.
setDate
(
date
.
toISODate
());
}
if
(
once
&&
this
.
ready
&&
first
)
{
console
.
log
(
"
load up
"
,
date
.
toISODate
());
this
.
ready
=
false
;
this
.
fetchMore
(
date
.
minus
({
days
:
this
.
dayIncrement
}
).
toISODate
(),
date
.
minus
({
days
:
1
}
).
toISODate
(),
()
=>
{
this
.
fixScrollPos
(
document
.
documentElement
.
scrollHeight
,
document
.
documentElement
.
scrollTop
,
);
}
,
);
once
=
false
;
}
else
if
(
once
&&
this
.
ready
&&
last
)
{
console
.
log
(
"
load down
"
,
date
.
toISODate
());
this
.
ready
=
false
;
this
.
fetchMore
(
date
.
plus
({
days
:
1
}
).
toISODate
(),
date
.
plus
({
days
:
this
.
dayIncrement
}
).
toISODate
(),
()
=>
{
this
.
ready
=
true
;
}
,
);
once
=
false
;
}
}
}
;
}
,
// Improve me?
// The navigation logic could be a bit simpler if the current days
// where known as a sorted array (= result of groupDocsByDay) But
// then the list would need its own component and this gets rather
// complicated. Then the calendar could also show the present days
// / gray out the missing.
//
// Next two: arg date is ts object
findPrev
(
date
)
{
return
this
.
$refs
.
days
.
map
((
day
)
=>
day
.
date
)
.
sort
()
.
reverse
()
.
find
((
date2
)
=>
date2
<
date
);
}
,
findNext
(
date
)
{
return
this
.
$refs
.
days
.
map
((
day
)
=>
day
.
date
)
.
sort
()
.
find
((
date2
)
=>
date2
>
date
);
}
,
gotoDate
(
date
)
{
const
present
=
this
.
$refs
.
days
.
find
(
(
day
)
=>
day
.
date
.
toISODate
()
===
date
,
);
if
(
present
)
{
// React immediatly -> smoother navigation
// Also intersect handler does not always react to scrollIntoView
this
.
setDate
(
date
);
present
.
focus
(
"
smooth
"
);
}
else
{
const
prev
=
this
.
findPrev
(
DateTime
.
fromISO
(
date
));
const
next
=
this
.
findNext
(
DateTime
.
fromISO
(
date
));
if
(
prev
&&
next
)
{
// In between two present days -> goto prev
this
.
gotoDate
(
prev
.
toISODate
());
}
else
{
// Outsite present day range
this
.
resetDate
(
date
);
}
}
}
,
gotoPrev
()
{
const
prev
=
this
.
findPrev
(
DateTime
.
fromISO
(
this
.
currentDate
));
if
(
prev
)
{
this
.
gotoDate
(
prev
.
toISODate
());
}
}
,
gotoNext
()
{
const
next
=
this
.
findNext
(
DateTime
.
fromISO
(
this
.
currentDate
));
if
(
next
)
{
this
.
gotoDate
(
next
.
toISODate
());
}
}
,
}
,
created
()
{
this
.
resetDate
();
}
,
}
;
<
/script
>
Loading