Resolve "Add rules and permissions"
Closes #73 (closed)
Closes #79 (closed)
Merge request reports
Activity
added part::backend part::frontend prio::1 type::bug labels
@yuha Please give feedback when your task will be finished.
-
I think the persons someone can select to register an absence should be filtered according to one's permissions. @yuha
assigned to @nik
-
@nik Please review as soon as it's possible for you – that would be very nice. (Despite it's still WIP.)
- Resolved by Jonathan Weth
Looks good on first glance.
However, I tend to not merge this without at least basic black/white test cases for the most important permissions.
- Last reply by Hangzhi Yu
added 34 commits
-
e65b4cb2...a8b1b29c - 33 commits from branch
master - a85bcae6 - Merge branch 'master' into 73-add-rules-and-permissions
-
e65b4cb2...a8b1b29c - 33 commits from branch
added 1 commit
- c0e47390 - Merge branch 'master' into 73-add-rules-and-permissions
added 1 commit
- 2a84050c - Fix order of has_perm and perm check in lesson template
added 1 commit
- 45de9a0c - Merge branch 'master' into 73-add-rules-and-permissions
added 5 commits
- a85bcae6 - Merge branch 'master' into 73-add-rules-and-permissions
- c0e47390 - Merge branch 'master' into 73-add-rules-and-permissions
- 451cdb33 - Merge branch '73-add-rules-and-permissions' of...
- 2a84050c - Fix order of has_perm and perm check in lesson template
- 287cac5e - Merge branch '73-add-rules-and-permissions' of...
Toggle commit listadded 9 commits
-
c8791096...43e6be1f - 7 commits from branch
master - 95f16ef8 - Merge branch 'master' into 73-add-rules-and-permissions
- 6b0eedfd - Fix lint issues and reformat files
-
c8791096...43e6be1f - 7 commits from branch
added 1 commit
- 93203b44 - Move annotate before union because annotating works only before union
added 1 commit
- fbbb6020 - Fix permission names and core/alsijil relation
added 1 commit
- f3cc545c - Convert pks of lesson periods to list to simplify query
added 10 commits
-
b1978f7a...607ae327 - 8 commits from branch
master - 4cf0c8e6 - Merge branch 'master' into 73-add-rules-and-permissions
- b3df531e - Merge branch '73-add-rules-and-permissions' of...
-
b1978f7a...607ae327 - 8 commits from branch
added 3 commits
-
26b63e39...303df022 - 2 commits from branch
master - 07ca4f09 - Merge branch 'master' into 73-add-rules-and-permissions
-
26b63e39...303df022 - 2 commits from branch
mentioned in issue #81 (closed)
- Resolved by Jonathan Weth
TODO for @yuha
- Add permissions for management of excuse types
- Remove personal note permissions (if !68 (merged) is merged)
- Add permissions for management of extra marks (if !68 (merged) is merged)
Edited by Jonathan Weth - Last reply by Jonathan Weth
-
@yuha I don't know if I already had written or said it, but please also pay attention to substitutions (substitution teachers can access a lesson as well as regular teachers etc.)
added 34 commits
-
0292d973...579f7532 - 32 commits from branch
master - 9cff3804 - Merge branch 'master' into 73-add-rules-and-permissions
- 62c3ea5d - Add rules&permissions for excuse types
-
0292d973...579f7532 - 32 commits from branch
added 1 commit
- 63c96016 - Also check whether a person is a teacher in a LessonSubstitution in is_lesson_teacher
-
As !68 (merged) is merged, it would be great if you could do the tasks in the comment above.
added 48 commits
-
63c96016...0b8aa003 - 45 commits from branch
master - 5143e011 - Merge branch 'master' into 73-add-rules-and-permissions
- 7652c383 - Remove rests of personal note filters
- 780fd921 - Reformat
Toggle commit list-
63c96016...0b8aa003 - 45 commits from branch
- Resolved by Jonathan Weth
TODO:
- Filter personal notes in overview of previous lessons (currently there are shown all personal notes of the previous lesson)
Edited by Jonathan Weth - Last reply by Hangzhi Yu