Skip to content
Snippets Groups Projects

Resolve "Break supervisions must be deleted cleanly"

Merged Jonathan Weth requested to merge 21-break-supervisions-must-be-deleted-cleanly into master

By using get_or_create with teacher in defaults for supervisions, supervisions weren't deleted if there was any (other/new) supervision in the same area, same break and same validity range. The reason for this is that there is a piece of code at the end of the importer which deletes all supervisions which weren't created in the lines with get_or_create. By using teacher as a normal get argument, new supervisions are correctly created and old ones are correctly detected as old ones which have to be deleted.

Closes #21 (closed)

Edited by Jonathan Weth

Merge request reports

Pipeline #6366 passed

Pipeline passed for bb633e34 on 21-break-supervisions-must-be-deleted-cleanly

Merged by Nik | KlampfradlerNik | Klampfradler 4 years ago (Mar 13, 2021 5:40pm UTC)

Loading

Pipeline #6369 passed

Pipeline: AlekSIS

#6373

    Pipeline passed for 49759568 on master

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
    Please register or sign in to reply
    Loading