Merge branch '567-impersonation-page-looks-disgusting' into 'master'

Resolve "Impersonation page looks disgusting "

Closes #567

See merge request !815

CHANGELOG.rst

@@ -25,6 +25,12 @@ Changed
 
 * Docker base image ships PostgreSQL 14 client binaries for maximum compatibility
 
+Removed
+~~~~~~~
+
+* Remove impersonation page. Use the impersonation button on the person
+  detail view instead.
+
 `2.2.1_ – 2021-12-02
 --------------------
 

aleksis/core/menus.py

@@ -183,17 +183,6 @@ MENUS = {
                         ),
                     ],
                 },
-                {
-                    "name": _("Impersonation"),
-                    "url": "impersonate-list",
-                    "icon": "people",
-                    "validators": [
-                        (
-                            "aleksis.core.util.predicates.permission_validator",
-                            "core.impersonate_rule",
-                        ),
-                    ],
-                },
                 {
                     "name": _("Configuration"),
                     "url": "preferences_site",

aleksis/core/templates/impersonate/list_users.html

-{# -*- engine:django -*- #}
-{# Derived from the original template in django-impersonate #}
-
-{% extends "core/base.html" %}
-{% load i18n %}
-
-{% block browser_title %}{% trans "Impersonate" %}{% endblock %}
-{% block page_title %}{% trans "Impersonate" %}{% endblock %}
-
-{% block content %}
-  {% if page.object_list %}
-    <div class="collection">
-      {% for user in page.object_list %}
-        <a class="collection-item" href="{% url 'impersonate-start' user.pk %}{{ redirect }}">
-          {{ user }}
-        </a>
-      {% endfor %}
-    </div>
-  {% endif %}
-
-  {% if page.has_previous %}
-    <a href="{% url 'impersonate-list' %}?page={{ page.previous_page_number }}">Previous Page</a> &nbsp;
-  {% endif %}
-
-  {% if page.has_next %}
-    <a href="{% url 'impersonate-list' %}?page={{ page.next_page_number }}">Next Page</a> &nbsp;
-  {% endif %}
-{% endblock %}