Merge branch...

Merge branch '683-attributeerror-at-about-anonymoususer-object-has-no-attribute-person' into 'master'

Resolve "AttributeError at /about/: 'AnonymousUser' object has no attribute 'person'"

Closes #683

See merge request !1006

CHANGELOG.rst

@@ -25,6 +25,7 @@ Fixed
 * The icons in the account menu were still the old ones.
 * Due to a merge error, the once removed account menu in the sidenav appeared again.
 * Scheduled notifications were shown on dashboard before time.
+* Remove broken notifications menu item in favor of item next to account menu.
 
 Changed
 ~~~~~~~

aleksis/core/menus.py

 from django.conf import settings
 from django.utils.translation import gettext_lazy as _
 
-from .util.core_helpers import unread_notifications_badge
-
 MENUS = {
     "NAV_MENU_CORE": [
         {
@@ -37,18 +35,6 @@ MENUS = {
                 ("aleksis.core.util.predicates.permission_validator", "core.view_dashboard_rule")
             ],
         },
-        {
-            "name": _("Notifications"),
-            "url": "notifications",
-            "svg_icon": "mdi:bell-outline",
-            "badge": unread_notifications_badge,
-            "validators": [
-                (
-                    "aleksis.core.util.predicates.permission_validator",
-                    "core.view_notifications_rule",
-                ),
-            ],
-        },
         {
             "name": _("Admin"),
             "url": "#",

aleksis/core/util/core_helpers.py

@@ -321,11 +321,6 @@ def generate_random_code(length, packet_size) -> str:
     return get_random_string(packet_size * length).lower()
 
 
-def unread_notifications_badge(request: HttpRequest) -> int:
-    """Generate badge content with the number of unread notifications."""
-    return request.user.person.unread_notifications_count
-
-
 def monkey_patch() -> None:  # noqa
     """Monkey-patch dependencies for special behaviour."""
     # Unwrap promises in JSON serializer instead of stringifying