Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
A
AlekSIS-Core
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package Registry
Container Registry
Model registry
Operate
Terraform modules
Monitor
Service Desk
Analyze
Contributor analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
AlekSIS®
Official
AlekSIS-Core
Commits
3b293f8e
Commit
3b293f8e
authored
1 year ago
by
Jonathan Weth
Browse files
Options
Downloads
Plain Diff
Merge branch '878-extensible-forms-broken' into 'master'
Resolve "Extensible forms broken" Closes
#878
See merge request
!1285
parents
1d00dade
303c8f33
No related branches found
Branches containing commit
No related tags found
Tags containing commit
1 merge request
!1285
Resolve "Extensible forms broken"
Pipeline
#135432
canceled
1 year ago
Stage: prepare
Stage: test
Stage: build
Stage: publish
Stage: docker
Stage: deploy
Changes
2
Pipelines
1
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
CHANGELOG.rst
+1
-0
1 addition, 0 deletions
CHANGELOG.rst
aleksis/core/mixins.py
+15
-1
15 additions, 1 deletion
aleksis/core/mixins.py
with
16 additions
and
1 deletion
CHANGELOG.rst
+
1
−
0
View file @
3b293f8e
...
...
@@ -18,6 +18,7 @@ Fixed
* When navigating from legacy to legacy page, the latter would reload once for no reason.
* The oauth authorization page was not accessible when the service worker was active.
* [Docker] Clear obsolete bundle parts when adding apps using ONBUILD
* Extensible forms that used a subset of fields did not render properly
`3.1.1`_ - 2023-07-01
---------------------
...
...
This diff is collapsed.
Click to expand it.
aleksis/core/mixins.py
+
15
−
1
View file @
3b293f8e
...
...
@@ -27,7 +27,7 @@ from dynamic_preferences.types import FilePreference
from
guardian.admin
import
GuardedModelAdmin
from
guardian.core
import
ObjectPermissionChecker
from
jsonstore.fields
import
IntegerField
,
JSONFieldMixin
from
material.base
import
Layout
,
LayoutNode
from
material.base
import
Fieldset
,
Layout
,
LayoutNode
from
polymorphic.base
import
PolymorphicModelBase
from
polymorphic.managers
import
PolymorphicManager
from
polymorphic.models
import
PolymorphicModel
...
...
@@ -449,6 +449,20 @@ class ExtensibleForm(ModelForm, metaclass=_ExtensibleFormMetaclass):
cls
.
base_layout
.
append
(
node
)
cls
.
layout
=
Layout
(
*
cls
.
base_layout
)
visit_nodes
=
[
node
]
while
visit_nodes
:
current_node
=
visit_nodes
.
pop
()
if
isinstance
(
current_node
,
Fieldset
):
visit_nodes
+=
node
.
elements
else
:
field_name
=
(
current_node
if
isinstance
(
current_node
,
str
)
else
current_node
.
field_name
)
field
=
fields_for_model
(
cls
.
_meta
.
model
,
[
field_name
])[
field_name
]
cls
.
_meta
.
fields
.
append
(
field_name
)
cls
.
base_fields
[
field_name
]
=
field
setattr
(
cls
,
field_name
,
field
)
class
BaseModelAdmin
(
GuardedModelAdmin
,
ObjectPermissionsModelAdmin
):
"""
A base class for ModelAdmin combining django-guardian and rules.
"""
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment