Merge branch '586-accountsignupform-accesses-database-on-instantiation' into 'master'

Resolve "AccountSignupForm accesses database on instantiation"

Closes #586

See merge request !846

CHANGELOG.rst

@@ -9,6 +9,12 @@ and this project adheres to `Semantic Versioning`_.
 Unreleased
 ----------
 
+Fixed
+~~~~~
+
+* Remove left-over reference to preferences in a form definition that caused
+  form extensions in downstream apps to break
+
 `2.4`_ – 2021-12-24
 -------------------
 

aleksis/core/forms.py

@@ -582,8 +582,6 @@ class AccountRegisterForm(SignupForm, ExtensibleForm):
 
     password1 = forms.CharField(label=_("Password"), widget=forms.PasswordInput)
 
-    privacy_policy = get_site_preferences()["footer__privacy_url"]
-
     if settings.SIGNUP_PASSWORD_ENTER_TWICE:
         password2 = forms.CharField(label=_("Password (again)"), widget=forms.PasswordInput)