Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
A
AlekSIS-Core
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package Registry
Container Registry
Model registry
Operate
Terraform modules
Monitor
Service Desk
Analyze
Contributor analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
AlekSIS®
Official
AlekSIS-Core
Commits
48e9fe85
Verified
Commit
48e9fe85
authored
3 years ago
by
Nik | Klampfradler
Browse files
Options
Downloads
Patches
Plain Diff
Properly report I/O errors in backup check
parent
6f895443
No related branches found
Branches containing commit
No related tags found
Tags containing commit
1 merge request
!920
Resolve "Status page throws internal server error if backup directory not found"
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
CHANGELOG.rst
+1
-0
1 addition, 0 deletions
CHANGELOG.rst
aleksis/core/health_checks.py
+7
-1
7 additions, 1 deletion
aleksis/core/health_checks.py
with
8 additions
and
1 deletion
CHANGELOG.rst
+
1
−
0
View file @
48e9fe85
...
...
@@ -21,6 +21,7 @@ Fixed
* Phone numbers were not properly linked and suboptimally formatted on person page
* Favicon upload failed with S3 storage.
* Some preferences were required when they shouldn't, and vice versa.
* IO errors on accessing backup directory in health check are now properly reported
`2.6`_ - 2022-01-10
-------------------
...
...
This diff is collapsed.
Click to expand it.
aleksis/core/health_checks.py
+
7
−
1
View file @
48e9fe85
...
...
@@ -33,7 +33,13 @@ class BaseBackupHealthCheck(BaseHealthCheckBackend):
def
check_status
(
self
):
storage
=
get_storage
()
backups
=
storage
.
list_backups
(
content_type
=
self
.
content_type
)
try
:
backups
=
storage
.
list_backups
(
content_type
=
self
.
content_type
)
except
Exception
as
ex
:
self
.
add_error
(
_
(
"
Error accessing backup storage: {}
"
).
format
(
str
(
ex
)))
return
if
backups
:
last_backup
=
backups
[:
1
]
last_backup_time
=
dbbackup_utils
.
filename_to_date
(
last_backup
[
0
])
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment