Merge branch 'revert-c863a33b' into 'master'

Revert "Merge branch '818-links-in-object-column-of-data-check-table-is-broken' into 'master'"

See merge request !1231

CHANGELOG.rst

@@ -63,7 +63,6 @@ Fixed
 * 2FA via messages or phone calls didn't work.
 * [Dev] Site reference on extensible models can no longer cause name clashes
   because of its related name.
-* Links to data check objects did not work properly.
 
 Removed
 ~~~~~~~

aleksis/core/templates/core/data_check/list.html

@@ -2,7 +2,6 @@
 
 {% extends "core/base.html" %}
 {% load data_helpers %}
-{% load html_helpers %}
 
 {% load i18n %}
 {% load render_table from django_tables2 %}
@@ -60,11 +59,9 @@
                 <td>{{ result.related_object }}</td>
                 <td>{{ result.related_check.problem_name }}</td>
                 <td>
-		  {% if result.related_object.get_absolute_url %}
-                  <a class="btn-flat waves-effect waves-light" href="{{ result.related_object.get_absolute_url|remove_prefix:"/django/" }}" target="_blank">
+                  <a class="btn-flat waves-effect waves-light" href="{{ result.related_object.get_absolute_url }}">
                     {% trans "Show object" %}
                   </a>
-		  {% endif %}
                 </td>
                 <td>
                   {% for option_name, option in result.related_check.solve_options.items %}

aleksis/core/templatetags/html_helpers.py

 import random
 import string
-from urllib.parse import urlparse
 
 from django import template
 from django.shortcuts import reverse
@@ -29,24 +28,6 @@ def add_class_to_el(value: str, arg: str) -> str:
     return str(soup)
 
 
-@register.filter
-def remove_prefix(value: str, prefix: str) -> str:
-    """Remove prefix of a url.
-
-    :Example:
-
-    .. code-block::
-
-        {{ object.get_absolute_url|remove_prefix: "/django/" }}
-    """
-    url = urlparse(value)
-
-    if url.path.startswith(prefix):
-        url = url._replace(path=url.path[len(prefix) :])
-
-    return url.geturl()
-
-
 @register.simple_tag
 def generate_random_id(prefix: str, length: int = 10) -> str:
     """Generate a random ID for templates.