Skip to content
Snippets Groups Projects
Verified Commit 6619f125 authored by Nik | Klampfradler's avatar Nik | Klampfradler
Browse files

Account for recursive members/owners on group m2m change

parent d8dc709b
No related branches found
No related tags found
No related merge requests found
Pipeline #51853 failed
......@@ -15,6 +15,7 @@ Fixed
* PDF generation failed with S3 storage due to incompatibility with boto3
* Form for editing group type displayed irrelevant fields
* Permission groups could get outdated if re-assigning a user account to a different person
* Permission groups could get out of sync for nested groups
`2.7`_ - 2022-01-24
-------------------
......
......@@ -612,9 +612,9 @@ class Group(SchoolTermRelatedExtensibleModel):
dj_group, _ = DjangoGroup.objects.get_or_create(name=self.name)
dj_group.user_set.set(
list(
self.members.filter(user__isnull=False)
self.members_recursive.filter(user__isnull=False)
.values_list("user", flat=True)
.union(self.owners.filter(user__isnull=False).values_list("user", flat=True))
.union(self.owners_recursive.filter(user__isnull=False).values_list("user", flat=True))
)
)
dj_group.save()
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment