Skip to content
Snippets Groups Projects
Commit 812b56e5 authored by Jonathan Weth's avatar Jonathan Weth :keyboard:
Browse files

Catch excecptions in objectgetter_optional e. g. if a user has no person

parent 026ac068
No related branches found
No related tags found
1 merge request!608Catch excecptions in objectgetter_optional e. g. if a user has no person
Pipeline #10821 passed
......@@ -225,11 +225,14 @@ def objectgetter_optional(
) -> Callable[[HttpRequest, Optional[int]], Model]:
"""Get an object by pk, defaulting to None."""
def get_object(request: HttpRequest, id_: Optional[int] = None, **kwargs) -> Model:
def get_object(request: HttpRequest, id_: Optional[int] = None, **kwargs) -> Optional[Model]:
if id_ is not None:
return get_object_or_404(model, pk=id_)
else:
return eval(default) if default_eval else default # noqa:S307
try:
return eval(default) if default_eval else default # noqa:S307
except (AttributeError, KeyError, IndexError):
return None
return get_object
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment