Add permission for personal details

aleksis/core/migrations/0023_add_permissions_person.py

@@ -12,6 +12,6 @@ class Migration(migrations.Migration):
     operations = [
         migrations.AlterModelOptions(
             name='person',
-            options={'ordering': ['last_name', 'first_name'], 'permissions': (('view_address', 'Can view address'), ('view_contact_details', 'Can view contact details'), ('view_photo', 'Can view photo'), ('view_person_groups', 'Can view persons groups')), 'verbose_name': 'Person', 'verbose_name_plural': 'Persons'},
+            options={'ordering': ['last_name', 'first_name'], 'permissions': (('view_address', 'Can view address'), ('view_contact_details', 'Can view contact details'), ('view_photo', 'Can view photo'), ('view_personal_details', 'Can view personal details'), ('view_person_groups', 'Can view persons groups')), 'verbose_name': 'Person', 'verbose_name_plural': 'Persons'},
         ),
     ]

aleksis/core/models.py

@@ -100,6 +100,7 @@ class Person(ExtensibleModel):
             ("view_contact_details", _("Can view contact details")),
             ("view_photo", _("Can view photo")),
             ("view_person_groups", _("Can view persons groups")),
+            ("view_personal_details", _("Can view personal details")),
         )
 
     icon_ = "person"

aleksis/core/rules.py

@@ -131,3 +131,9 @@ add_perm("core.view_people_menu", has_person & (view_persons_predicate | view_gr
 # View admin menu
 view_admin_menu_predicate = has_person & (manage_data_predicate | manage_school_predicate | impersonate_predicate | view_system_status_predicate | view_announcements_predicate)
 add_perm("core.view_admin_menu", view_admin_menu_predicate)
+
+# View person personal details
+view_personal_details_predicate = has_person & (
+    has_global_perm("core.view_personal_details") | has_object_perm("core.view_personal_details") | is_current_person
+)
+add_perm("core.view_personal_details", view_personal_details_predicate)

aleksis/core/templates/core/person_full.html

@@ -77,12 +77,15 @@
             <td colspan="3">{{ person.email }}</td>
           </tr>
         {% endif %}
-        <tr>
-          <td>
-            <i class="material-icons small">cake</i>
-          </td>
-          <td colspan="3">{{ person.date_of_birth|date }}</td>
-        </tr>
+        {% has_perm 'core.view_personal_details' user person as can_view_personal_details %}
+        {% if can_view_personal_details %}
+          <tr>
+            <td>
+              <i class="material-icons small">cake</i>
+            </td>
+            <td colspan="3">{{ person.date_of_birth|date }}</td>
+          </tr>
+        {% endif %}
       </table>
     </div>
   </div>