Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
A
AlekSIS-Core
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package Registry
Container Registry
Model registry
Operate
Terraform modules
Monitor
Service Desk
Analyze
Contributor analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
AlekSIS®
Official
AlekSIS-Core
Merge requests
!164
Fix some mistakes in app config system check
Code
Review changes
Check out branch
Download
Patches
Plain diff
Merged
Fix some mistakes in app config system check
bugfix/system-check-mistakes
into
master
Overview
0
Commits
4
Pipelines
1
Changes
1
Merged
Nik | Klampfradler
requested to merge
bugfix/system-check-mistakes
into
master
5 years ago
Overview
0
Commits
4
Pipelines
1
Changes
1
Expand
0
0
Merge request reports
Compare
master
master (base)
and
latest version
latest version
4ece0c14
4 commits,
5 years ago
1 file
+
4
−
4
Inline
Compare changes
Side-by-side
Inline
Show whitespace changes
Show one file at a time
aleksis/core/checks.py
+
4
−
4
Options
@@ -9,7 +9,7 @@ from .util.apps import AppConfig
@register
(
Tags
.
compatibility
)
def
check_app_configs_base_class
(
app_configs
:
Optional
[
django
.
apps
.
registry
.
Apps
]
=
None
,
**
kwargs
)
->
None
:
)
->
list
:
"""
Checks whether all apps derive from AlekSIS
'
s base app config
"""
results
=
[]
@@ -17,11 +17,11 @@ def check_app_configs_base_class(
if
app_configs
is
None
:
app_configs
=
django
.
apps
.
apps
.
get_app_configs
()
for
app_config
in
app_configs
:
if
app_config
.
name
.
startswith
(
"
aleksis.apps.
"
)
and
not
isinstance
(
app_config
,
AppConfig
):
for
app_config
in
filter
(
lambda
c
:
c
.
name
.
startswith
(
"
aleksis.
"
),
app_configs
)
:
if
not
isinstance
(
app_config
,
AppConfig
):
results
.
append
(
Warning
(
"
App config %s does not derive from aleksis.core.util.apps.AppConfig.
"
,
"
App config %s does not derive from aleksis.core.util.apps.AppConfig.
"
%
app_config
.
name
,
hint
=
"
Ensure the app uses the correct base class for all registry functionality to work.
"
,
obj
=
app_config
,
id
=
"
aleksis.core.W001
"
,
Loading