Resolve "Add CSS/JS static files for material select2"

Closes #222 (closed)

changed milestone to %2.0a2

added part::frontend label

added 1 commit

• 06f60155 - Add yarn dependency "select2-materialize" in settings.py so that...

Compare with previous version

assigned to @nik

added part::backend label

unmarked as a Work In Progress

I guess it can be merged now.

Without adding the JS and CSS to ANY_JS and in the base template?

Probably this is a silly question, but why does it have to be added to ANY_JS?

So you can refer to it in your HTML to load it.

But can't I also use <script type="text/javascript" src='{% static 'select2-materialize/index.js' %}'></script>?

And isn't loading it in the base template inefficient since it is only needed in one place?

But can't I also use <script type="text/javascript" src='{% static 'select2-materialize/index.js' %}'></script>?

As long as it is inside STATIC_ROOT, yes. But production systems do not serve from node_modules, but e.g. from Debian's javascript-common. Paths to frontend dependencies must therefore be configurable.

And isn't loading it in the base template inefficient since it is only needed in one place?

Yes, using form media seems preferrable.

added 1 commit

• 02e65663 - Add JS/CSS to ANY_JS to be able to configure paths for frontend dependencies

Compare with previous version

You mixed up JS and CSS in ANY_JS.

Also, that change to the default for DEBUG looks quite strange. I can't even imagine any reason to touch it.

added 1 commit

• b7805eb0 - Fixed mixed up JS/CSS in ANY_JS, turned off DEBUG

Compare with previous version

Please remove the unrelated changes from the commit history by rebasing. Also fix the URL mixup by rebasing, amending.

Probably the easiest way to do that now is squashing the two last commits into one.

added 1 commit

• 28abbbf9 - Add JS/CSS to ANY_JS to be able to configure paths for frontend dependencies

Compare with previous version

resolved all threads