Skip to content
Snippets Groups Projects

Resolve "Add overview page for celery task results"

Merged Tom Teichler requested to merge 223-add-overview-page-for-celery-task-results into master

Closes #223 (closed)

Edited by Tom Teichler

Merge request reports

Pipeline #2462 passed

Pipeline passed for 7d5e47d8 on 223-add-overview-page-for-celery-task-results

Approval is optional

Merged by Jonathan WethJonathan Weth 4 years ago (May 29, 2020 8:48pm UTC)

Merge details

  • Changes merged into master with 307532e9.
  • Deleted the source branch.
  • Auto-merge enabled

Pipeline #2466 failed

Pipeline failed for 307532e9 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Tom Teichler added 1 commit

    added 1 commit

    • e51f4a7a - Show celery task results on system status page

    Compare with previous version

  • Tom Teichler resolved all threads

    resolved all threads

  • Tom Teichler removed time spent

    removed time spent

  • If celery is not running, the following happens:

    Traceback (most recent call last):
      File "/home/wethjo/.cache/pypoetry/virtualenvs/aleksis-9WSQE4wq-py3.8/lib/python3.8/site-packages/django/core/handlers/exception.py", line 34, in inner
        response = get_response(request)
      File "/home/wethjo/.cache/pypoetry/virtualenvs/aleksis-9WSQE4wq-py3.8/lib/python3.8/site-packages/django/core/handlers/base.py", line 115, in _get_response
        response = self.process_exception_by_middleware(e, request)
      File "/home/wethjo/.cache/pypoetry/virtualenvs/aleksis-9WSQE4wq-py3.8/lib/python3.8/site-packages/django/core/handlers/base.py", line 113, in _get_response
        response = wrapped_callback(request, *callback_args, **callback_kwargs)
      File "/usr/lib/python3.8/contextlib.py", line 75, in inner
        return func(*args, **kwds)
      File "/home/wethjo/.cache/pypoetry/virtualenvs/aleksis-9WSQE4wq-py3.8/lib/python3.8/site-packages/rules/contrib/views.py", line 221, in _wrapped_view
        return view_func(request, *args, **kwargs)
      File "/home/wethjo/dev/AlekSIS/aleksis/core/views.py", line 303, in system_status
        job_list = list(inspect().registered_tasks().values())[0]
    
    Exception Type: AttributeError at /status/
    Exception Value: 'NoneType' object has no attribute 'values'
    Edited by Jonathan Weth
    • Resolved by Tom Teichler

      Tom and I discussed whether we wanted to display only tasks that already ran and yielded a result at least once, or all registered tasks (because the first would mean to just query the TaskResult model, the latter introspecting celery).

  • Tom Teichler added 8 commits

    added 8 commits

    • e51f4a7a...aa288c4e - 7 commits from branch master
    • 00dec64f - Merge branch 'master' into 223-add-overview-page-for-celery-task-results

    Compare with previous version

  • Tom Teichler added 1 commit

    added 1 commit

    • b27f2321 - Check if registered_tasks() is None

    Compare with previous version

  • Tom Teichler unmarked as a Work In Progress

    unmarked as a Work In Progress

  • Tom Teichler resolved all threads

    resolved all threads

  • Seems to be fine. I would suggest to do a last review on Dev meeting next week together with the rest.

  • Jonathan Weth added 1 deleted label

    added 1 deleted label

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading