Skip to content
Snippets Groups Projects

Resolve "Let apps add extra permissions to models"

Merged Hangzhi Yu requested to merge 273-let-apps-add-extra-permissions-to-models into master
All threads resolved!

Closes #273 (closed)

Edited by Hangzhi Yu

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Jonathan Weth assigned to @nik and unassigned @hansegucker

    assigned to @nik and unassigned @hansegucker

  • Hangzhi Yu added 1 commit

    added 1 commit

    • 57956aac - Add method to inject permissions to ExtensibleModels dynamically

    Compare with previous version

  • Jonathan Weth resolved all threads

    resolved all threads

  • Jonathan Weth added 2 commits

    added 2 commits

    • 4235f264 - Fix usage of get_or_create for adding extra permissions to models
    • 7da8a589 - Fix lint issues

    Compare with previous version

  • Jonathan Weth added 3 commits

    added 3 commits

    • 7da8a589...3ffe64e2 - 2 commits from branch master
    • 626bfadf - Merge branch 'master' into 273-let-apps-add-extra-permissions-to-models

    Compare with previous version

  • Jonathan Weth resolved all threads

    resolved all threads

  • This approach seems to completely bypass the regular permission creation in Django. Even if it looks correct now, it carries the risk of breaking if permission management in Django changes. In essence, we get a part of the Django coe as a code copy we have to maintain.

    If you have considered these issues and have arguments against it, please describe those and why you think the code is stable.

  • Jonathan Weth added 22 commits

    added 22 commits

    • 626bfadf...9d7bbf6a - 21 commits from branch master
    • 97d76f59 - Merge branch 'master' into 273-let-apps-add-extra-permissions-to-models

    Compare with previous version

  • mentioned in commit 1d045dfb

  • Please register or sign in to reply
    Loading