Resolve "Creating translation files fails because circular import"

Closes #296 (closed)

aleksis/core/rules.py

-from rules import add_perm, always_allow
+import rules
 
 from .models import AdditionalField, Announcement, Group, GroupType, Person
 from .util.predicates import (
@@ -11,32 +11,32 @@ from .util.predicates import (
     is_notification_recipient,
 )
 
-add_perm("core", always_allow)
+rules.add_perm("core", rules.always_allow)
 
 # View dashboard
-add_perm("core.view_dashboard", has_person)
+rules.add_perm("core.view_dashboard", has_person)
 
 # Use search
 search_predicate = has_person & has_global_perm("core.search")
-add_perm("core.search", search_predicate)
+rules.add_perm("core.search", search_predicate)
 
 # View persons
 view_persons_predicate = has_person & (
     has_global_perm("core.view_person") | has_any_object("core.view_person", Person)
 )
-add_perm("core.view_persons", view_persons_predicate)
+rules.add_perm("core.view_persons", view_persons_predicate)
 
 # View person
 view_person_predicate = has_person & (
     has_global_perm("core.view_person") | has_object_perm("core.view_person") | is_current_person
 )
-add_perm("core.view_person", view_person_predicate)
+rules.add_perm("core.view_person", view_person_predicate)
 
 # View person address
 view_address_predicate = has_person & (
     has_global_perm("core.view_address") | has_object_perm("core.view_address") | is_current_person
 )
-add_perm("core.view_address", view_address_predicate)
+rules.add_perm("core.view_address", view_address_predicate)
 
 # View person contact details
 view_contact_details_predicate = has_person & (
@@ -44,13 +44,13 @@ view_contact_details_predicate = has_person & (
     | has_object_perm("core.view_contact_details")
     | is_current_person
 )
-add_perm("core.view_contact_details", view_contact_details_predicate)
+rules.add_perm("core.view_contact_details", view_contact_details_predicate)
 
 # View person photo
 view_photo_predicate = has_person & (
     has_global_perm("core.view_photo") | has_object_perm("core.view_photo") | is_current_person
 )
-add_perm("core.view_photo", view_photo_predicate)
+rules.add_perm("core.view_photo", view_photo_predicate)
 
 # View persons groups
 view_groups_predicate = has_person & (
@@ -58,96 +58,96 @@ view_groups_predicate = has_person & (
     | has_object_perm("core.view_person_groups")
     | is_current_person
 )
-add_perm("core.view_person_groups", view_groups_predicate)
+rules.add_perm("core.view_person_groups", view_groups_predicate)
 
 # Edit person
 edit_person_predicate = has_person & (
     has_global_perm("core.change_person") | has_object_perm("core.change_person")
 )
-add_perm("core.edit_person", edit_person_predicate)
+rules.add_perm("core.edit_person", edit_person_predicate)
 
 # Delete person
 delete_person_predicate = has_person & (
     has_global_perm("core.delete_person") | has_object_perm("core.delete_person")
 )
-add_perm("core.delete_person", delete_person_predicate)
+rules.add_perm("core.delete_person", delete_person_predicate)
 
 # Link persons with accounts
 link_persons_accounts_predicate = has_person & has_global_perm("core.link_persons_accounts")
-add_perm("core.link_persons_accounts", link_persons_accounts_predicate)
+rules.add_perm("core.link_persons_accounts", link_persons_accounts_predicate)
 
 # View groups
 view_groups_predicate = has_person & (
     has_global_perm("core.view_group") | has_any_object("core.view_group", Group)
 )
-add_perm("core.view_groups", view_groups_predicate)
+rules.add_perm("core.view_groups", view_groups_predicate)
 
 # View group
 view_group_predicate = has_person & (
     has_global_perm("core.view_group") | has_object_perm("core.view_group")
 )
-add_perm("core.view_group", view_group_predicate)
+rules.add_perm("core.view_group", view_group_predicate)
 
 # Edit group
 edit_group_predicate = has_person & (
     has_global_perm("core.change_group") | has_object_perm("core.change_group")
 )
-add_perm("core.edit_group", edit_group_predicate)
+rules.add_perm("core.edit_group", edit_group_predicate)
 
 # Delete group
 delete_group_predicate = has_person & (
     has_global_perm("core.delete_group") | has_object_perm("core.delete_group")
 )
-add_perm("core.delete_group", delete_group_predicate)
+rules.add_perm("core.delete_group", delete_group_predicate)
 
 # Assign child groups to groups
 assign_child_groups_to_groups_predicate = has_person & has_global_perm(
     "core.assign_child_groups_to_groups"
 )
-add_perm("core.assign_child_groups_to_groups", assign_child_groups_to_groups_predicate)
+rules.add_perm("core.assign_child_groups_to_groups", assign_child_groups_to_groups_predicate)
 
 # Edit school information
 edit_school_information_predicate = has_person & has_global_perm("core.change_school")
-add_perm("core.edit_school_information", edit_school_information_predicate)
+rules.add_perm("core.edit_school_information", edit_school_information_predicate)
 
 # Manage data
 manage_data_predicate = has_person & has_global_perm("core.manage_data")
-add_perm("core.manage_data", manage_data_predicate)
+rules.add_perm("core.manage_data", manage_data_predicate)
 
 # Mark notification as read
 mark_notification_as_read_predicate = has_person & is_notification_recipient
-add_perm("core.mark_notification_as_read", mark_notification_as_read_predicate)
+rules.add_perm("core.mark_notification_as_read", mark_notification_as_read_predicate)
 
 # View announcements
 view_announcements_predicate = has_person & (
     has_global_perm("core.view_announcement")
     | has_any_object("core.view_announcement", Announcement)
 )
-add_perm("core.view_announcements", view_announcements_predicate)
+rules.add_perm("core.view_announcements", view_announcements_predicate)
 
 # Create or edit announcement
 create_or_edit_announcement_predicate = has_person & (
     has_global_perm("core.add_announcement")
     & (has_global_perm("core.change_announcement") | has_object_perm("core.change_announcement"))
 )
-add_perm("core.create_or_edit_announcement", create_or_edit_announcement_predicate)
+rules.add_perm("core.create_or_edit_announcement", create_or_edit_announcement_predicate)
 
 # Delete announcement
 delete_announcement_predicate = has_person & (
     has_global_perm("core.delete_announcement") | has_object_perm("core.delete_announcement")
 )
-add_perm("core.delete_announcement", delete_announcement_predicate)
+rules.add_perm("core.delete_announcement", delete_announcement_predicate)
 
 # Use impersonate
 impersonate_predicate = has_person & has_global_perm("core.impersonate")
-add_perm("core.impersonate", impersonate_predicate)
+rules.add_perm("core.impersonate", impersonate_predicate)
 
 # View system status
 view_system_status_predicate = has_person & has_global_perm("core.view_system_status")
-add_perm("core.view_system_status", view_system_status_predicate)
+rules.add_perm("core.view_system_status", view_system_status_predicate)
 
 # View people menu (persons + objects)
-add_perm(
+rules.add_perm(
     "core.view_people_menu",
     has_person
     & (
@@ -164,14 +164,14 @@ view_personal_details_predicate = has_person & (
     | has_object_perm("core.view_personal_details")
     | is_current_person
 )
-add_perm("core.view_personal_details", view_personal_details_predicate)
+rules.add_perm("core.view_personal_details", view_personal_details_predicate)
 
 # Change site preferences
 change_site_preferences = has_person & (
     has_global_perm("core.change_site_preferences")
     | has_object_perm("core.change_site_preferences")
 )
-add_perm("core.change_site_preferences", change_site_preferences)
+rules.add_perm("core.change_site_preferences", change_site_preferences)
 
 # Change person preferences
 change_person_preferences = has_person & (
@@ -179,7 +179,7 @@ change_person_preferences = has_person & (
     | has_object_perm("core.change_person_preferences")
     | is_current_person
 )
-add_perm("core.change_person_preferences", change_person_preferences)
+rules.add_perm("core.change_person_preferences", change_person_preferences)
 
 # Change group preferences
 change_group_preferences = has_person & (
@@ -187,81 +187,81 @@ change_group_preferences = has_person & (
     | has_object_perm("core.change_group_preferences")
     | is_group_owner
 )
-add_perm("core.change_group_preferences", change_group_preferences)
+rules.add_perm("core.change_group_preferences", change_group_preferences)
 
 
 # Edit additional field
 change_additional_field_predicate = has_person & (
     has_global_perm("core.change_additionalfield") | has_object_perm("core.change_additionalfield")
 )
-add_perm("core.change_additionalfield", change_additional_field_predicate)
+rules.add_perm("core.change_additionalfield", change_additional_field_predicate)
 
 # Edit additional field
 create_additional_field_predicate = has_person & (
     has_global_perm("core.create_additionalfield") | has_object_perm("core.create_additionalfield")
 )
-add_perm("core.create_additionalfield", create_additional_field_predicate)
+rules.add_perm("core.create_additionalfield", create_additional_field_predicate)
 
 
 # Delete additional field
 delete_additional_field_predicate = has_person & (
     has_global_perm("core.delete_additionalfield") | has_object_perm("core.delete_additionalfield")
 )
-add_perm("core.delete_additionalfield", delete_additional_field_predicate)
+rules.add_perm("core.delete_additionalfield", delete_additional_field_predicate)
 
 # View additional fields
 view_additional_field_predicate = has_person & (
     has_global_perm("core.view_additionalfield")
     | has_any_object("core.view_additionalfield", AdditionalField)
 )
-add_perm("core.view_additionalfield", view_additional_field_predicate)
+rules.add_perm("core.view_additionalfield", view_additional_field_predicate)
 
 # Edit group type
 change_group_type_predicate = has_person & (
     has_global_perm("core.change_grouptype") | has_object_perm("core.change_grouptype")
 )
-add_perm("core.edit_grouptype", change_group_type_predicate)
+rules.add_perm("core.edit_grouptype", change_group_type_predicate)
 
 # Create group type
 create_group_type_predicate = has_person & (
     has_global_perm("core.create_grouptype") | has_object_perm("core.change_grouptype")
 )
-add_perm("core.create_grouptype", create_group_type_predicate)
+rules.add_perm("core.create_grouptype", create_group_type_predicate)
 
 
 # Delete group type
 delete_group_type_predicate = has_person & (
     has_global_perm("core.delete_grouptype") | has_object_perm("core.delete_grouptype")
 )
-add_perm("core.delete_grouptype", delete_group_type_predicate)
+rules.add_perm("core.delete_grouptype", delete_group_type_predicate)
 
 # View group types
 view_group_type_predicate = has_person & (
     has_global_perm("core.view_grouptype") | has_any_object("core.view_grouptype", GroupType)
 )
-add_perm("core.view_grouptype", view_group_type_predicate)
+rules.add_perm("core.view_grouptype", view_group_type_predicate)
 
 # Create person
 create_person_predicate = has_person & (
     has_global_perm("core.create_person") | has_object_perm("core.create_person")
 )
-add_perm("core.create_person", create_person_predicate)
+rules.add_perm("core.create_person", create_person_predicate)
 
 # Create group
 create_group_predicate = has_person & (
     has_global_perm("core.create_group") | has_object_perm("core.create_group")
 )
-add_perm("core.create_group", create_group_predicate)
+rules.add_perm("core.create_group", create_group_predicate)
 
 # School years
 view_school_term_predicate = has_person & has_global_perm("core.view_schoolterm")
-add_perm("core.view_schoolterm", view_school_term_predicate)
+rules.add_perm("core.view_schoolterm", view_school_term_predicate)
 
 create_school_term_predicate = has_person & has_global_perm("core.add_schoolterm")
-add_perm("core.create_schoolterm", create_school_term_predicate)
+rules.add_perm("core.create_schoolterm", create_school_term_predicate)
 
 edit_school_term_predicate = has_person & has_global_perm("core.change_schoolterm")
-add_perm("core.edit_schoolterm", edit_school_term_predicate)
+rules.add_perm("core.edit_schoolterm", edit_school_term_predicate)
 
 # View admin menu
 view_admin_menu_predicate = has_person & (
@@ -271,4 +271,4 @@ view_admin_menu_predicate = has_person & (
     | view_system_status_predicate
     | view_announcements_predicate
 )
-add_perm("core.view_admin_menu", view_admin_menu_predicate)
+rules.add_perm("core.view_admin_menu", view_admin_menu_predicate)