Skip to content
Snippets Groups Projects

Resolve "[About] Shows versions as "unknown""

Merged Resolve "[About] Shows versions as "unknown""
365-about-shows-versions-as-unknown into master
Merged Nik | Klampfradler requested to merge 365-about-shows-versions-as-unknown into master
  1. Feb 13, 2021
    • Nik | Klampfradler's avatar
      Rework `get_version` to not rely on import · 2c1009a7
      Nik | Klampfradler authored 
      What did I drink when I wrote the original code? The relative import
`from .. import __version__` in the utility code in core, of course,
always imported from `aleksis.core`, no matter the real `AppConfig`
that inherited the utility code. Thus, the versions always showed the
version of AlekSIS-Core everywhere (whose version information was
broken ever since we renamed AlekSIS to AlekSIS-Core).

This change decouples the `get_version` code from the package level
`__version__` information, which effectively becomes optional now.
      Verified
      2c1009a7
    • Nik | Klampfradler's avatar
      Fix distribution name for geting version · 0ead6f79
      Nik | Klampfradler authored
      Verified
      0ead6f79