Resolve "favicon / icon generation mauls database"

Closes #356 (closed) Closes #412 (closed)

added part::frontend type::bug workflow::confirmed + 1 deleted label

added 1 commit

• 998182d5 - Rewrite PWA icon handling to new django-favicons-plus API

Compare with previous version

added 1 commit

• faf82ebf - Rewrite PWA icon handling to new django-favicons-plus API

Compare with previous version

  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/.venv/lib/python3.9/site-packages/django/core/handlers/exception.py", line 47, in inner
    response = get_response(request)
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/.venv/lib/python3.9/site-packages/django/core/handlers/base.py", line 181, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/.venv/lib/python3.9/site-packages/rules/contrib/views.py", line 221, in _wrapped_view
    return view_func(request, *args, **kwargs)
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/aleksis/core/views.py", line 136, in index
    return render(request, "core/index.html", context)
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/.venv/lib/python3.9/site-packages/django/shortcuts.py", line 19, in render
    content = loader.render_to_string(template_name, context, request, using=using)
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/.venv/lib/python3.9/site-packages/django/template/loader.py", line 62, in render_to_string
    return template.render(context, request)
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/.venv/lib/python3.9/site-packages/django/template/backends/django.py", line 61, in render
    return self.template.render(context)
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/.venv/lib/python3.9/site-packages/django/template/base.py", line 170, in render
    return self._render(context)
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/.venv/lib/python3.9/site-packages/django/test/utils.py", line 100, in instrumented_test_render
    return self.nodelist.render(context)
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/.venv/lib/python3.9/site-packages/django/template/base.py", line 938, in render
    bit = node.render_annotated(context)
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/.venv/lib/python3.9/site-packages/django/template/base.py", line 905, in render_annotated
    return self.render(context)
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/.venv/lib/python3.9/site-packages/django/template/loader_tags.py", line 150, in render
    return compiled_parent._render(context)
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/.venv/lib/python3.9/site-packages/django/test/utils.py", line 100, in instrumented_test_render
    return self.nodelist.render(context)
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/.venv/lib/python3.9/site-packages/django/template/base.py", line 938, in render
    bit = node.render_annotated(context)
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/.venv/lib/python3.9/site-packages/django/template/base.py", line 905, in render_annotated
    return self.render(context)
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/.venv/lib/python3.9/site-packages/django/template/loader_tags.py", line 195, in render
    return template.render(context)
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/.venv/lib/python3.9/site-packages/django/template/base.py", line 172, in render
    return self._render(context)
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/.venv/lib/python3.9/site-packages/django/test/utils.py", line 100, in instrumented_test_render
    return self.nodelist.render(context)
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/.venv/lib/python3.9/site-packages/django/template/base.py", line 938, in render
    bit = node.render_annotated(context)
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/.venv/lib/python3.9/site-packages/django/template/base.py", line 905, in render_annotated
    return self.render(context)
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/.venv/lib/python3.9/site-packages/django/template/library.py", line 192, in render
    output = self.func(*resolved_args, **resolved_kwargs)
  File "/home/wethjo/dev/AlekSIS/apps/official/django-favicon-plus/favicon/templatetags/favtags.py", line 29, in place_favicon
    html = fav.as_html()
  File "/home/wethjo/dev/AlekSIS/apps/official/django-favicon-plus/favicon/models.py", line 115, in as_html
    for favicon in self.get_favicons(update=update):
  File "/home/wethjo/dev/AlekSIS/apps/official/django-favicon-plus/favicon/models.py", line 96, in get_favicons
    fav.generate_image()
  File "/home/wethjo/dev/AlekSIS/apps/official/django-favicon-plus/favicon/models.py", line 145, in generate_image
    tmp = Image.open(storage.open(self.faviconFK.faviconImage.name))
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/.venv/lib/python3.9/site-packages/django/core/files/storage.py", line 36, in open
    return self._open(name, mode)
  File "/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/.venv/lib/python3.9/site-packages/django/core/files/storage.py", line 231, in _open
    return File(open(self.path(name), mode))
IsADirectoryError: [Errno 21] Is a directory: '/home/wethjo/dev/AlekSIS/apps/official/AlekSIS-Core/aleksis/media'

added 23 commits

• faf82ebf...e546f60c - 22 commits from branch master
• 12ff4a86 - Rewrite PWA icon handling to new django-favicons-plus API

Compare with previous version

added 1 commit

• d6a94664 - Fix image saving

Compare with previous version

added 1 commit

• f046e2ff - Fix image saving

Compare with previous version

added 1 commit

• 93560627 - Do not make use of memoize for favicons

Compare with previous version

added 2 commits

• 2923449a - Monkey-patch Django's JSON encoder to unwrap promises
• 6c064bf8 - Merge branch '356-favicon-icon-generation-mauls-database' of...

Compare with previous version

added 1 commit

• 7233f1b2 - Fix typo

Compare with previous version

added 1 commit

• d58a3f7f - Use `encode()` to encode unwrapped lazy object

Compare with previous version

added 4 commits

• fc61d801 - Ensure that favicons are always created and updated
• a87196b5 - Merge branch '356-favicon-icon-generation-mauls-database' of...
• be098d0f - Fix import og JSONEncoder in monkey patch
• 06d973bf - Merge branch '356-favicon-icon-generation-mauls-database' of...

Compare with previous version

added 1 commit

• 3b83c327 - Fix monkey patch of JSONEncoder

Compare with previous version

marked this merge request as ready

changed the description

added 4 commits

• 3b83c327...942db4b5 - 2 commits from branch master
• 4416e8b0 - Merge branch 'master' into 356-favicon-icon-generation-mauls-database
• b606d922 - Update django-favicon-plus-reloaded to 1.1.0

Compare with previous version

added 1 commit

• d117f834 - Update django-favicon-plus-reloaded to 1.1.0

Compare with previous version

enabled an automatic merge when the pipeline for d117f834 succeeds

aborted the automatic merge because source branch was updated

added 2 commits

• b144caf3 - Move icon generation to maintain_default_data
• af70dd32 - Reformat

Compare with previous version

assigned to @hansegucker and unassigned @nik

added 8 commits

• af70dd32...0051b0bd - 7 commits from branch master
• 301bc166 - Merge branch 'master' into 356-favicon-icon-generation-mauls-database

Compare with previous version

mentioned in commit 026ac068

merged