Skip to content
Snippets Groups Projects

Add base template for plain prints and optimize PDF generation

Merged Jonathan Weth requested to merge feature/template-plain-prints into master
All threads resolved!

Necessary for AlekSIS-App-Kort

Edited by Jonathan Weth

Merge request reports

Pipeline #93255 passed with warnings

Pipeline passed with warnings for 526ea1da on feature/template-plain-prints

Approval is optional

Merged by Nik | KlampfradlerNik | Klampfradler 2 years ago (Oct 12, 2022 5:49pm UTC)

Merge details

  • Changes merged into master with 04da58d4.
  • Deleted the source branch.

Pipeline #93256 passed

Pipeline: AlekSIS

#93264

    Pipeline passed for 04da58d4 on master

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
    • Resolved by Jonathan Weth

      Please open a follow-up issue in the distribution repository to add an upgrade note for the new system dependency.

      Also, does this change reproducibly, and proven, fix the core issue of PDFs being partially rendered? I see no explicit wait in the Selenium code.

      Maybe adding a regression test would be helpful (you can look at the OAuth regression tests for how to add a testing app, and then provide a test view that sleeps for 500ms or so and returns an image afterwards).

  • Jonathan Weth resolved all threads

    resolved all threads

  • Jonathan Weth added 1 commit

    added 1 commit

    Compare with previous version

  • Jonathan Weth resolved all threads

    resolved all threads

  • added 21 commits

    Compare with previous version

  • mentioned in commit 04da58d4

  • Please register or sign in to reply
    Loading